Add secondary pattern support for pattern arg
#1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! Thanks so much for addressing this so quickly! :D I really appreciate it. |
|
@erhoppe you’re welcome! I forgot to follow up on this in the Issue but I’m glad you noticed this. Let me know if there are any shortcomings or other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides support for secondary patterns whereby segments of a pattern may be removed should there be a missing value within the new
<</>>delimiters.For example,
"<<{1} <<{2} << ({3}) >>>>>>"might yield"a b (c)"given no position having missing values. The same pattern would yield"a "with{2}being missing and"a b "with{3}missing.Fixes: #1118