Skip to content

Allow the table stub to participate in column merging operations #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 13, 2022

Conversation

rich-iannone
Copy link
Member

This PR allows the stub contents to freely merge with other columns (using the cols_merge*() functions). With this, the stub won't be accidentally hidden since the logic behind that was altered to exclude the hiding of columns designated as the stub.

@rich-iannone rich-iannone marked this pull request as ready for review November 11, 2022 21:25
@rich-iannone rich-iannone requested a review from cscheid November 11, 2022 21:25
Copy link
Member

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cscheid cscheid merged commit 01c26a0 into master Nov 13, 2022
@rich-iannone rich-iannone deleted the cols-merge-stub-include branch November 13, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants