Skip to content

Add container padding options #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2022
Merged

Add container padding options #1116

merged 5 commits into from
Nov 10, 2022

Conversation

rich-iannone
Copy link
Member

This adds two options in tab_options() for setting the left/right and top/bottom padding on the table's container (HTML only). This is necessary since the lack of default padding (and any means to set it) results in tables being uncomfortable close to paragraphs above and below.

Fixes: #1105
Fixes: #590

@rich-iannone rich-iannone marked this pull request as ready for review November 10, 2022 05:45
@rich-iannone rich-iannone requested a review from cscheid November 10, 2022 05:45
Copy link
Member

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cscheid cscheid merged commit cf15444 into master Nov 10, 2022
@rich-iannone rich-iannone deleted the container-padding branch November 10, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants