Enhance CSS-inlining within as_raw_html()
#1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
as_raw_html()function is useful for generating an HTML string for email message bodies and for HTML embedding purposes (expressly withinline_css = TRUE). While the CSS-inlining has been adequate it is: (1) slow, and (2) underpowered and can't keep up with additions to the SCSS styles. This is solved by using an external package that uses thejuiceJS library. This solution is far more performant and correct. Given the degree to which inlining problems are being seen (this especially impacts HTML email sending with gt tables), it is necessary to improve this part of the package.Fixes: #1093
Fixes: #915
Fixes: #858
Fixes: #837
Fixes: #540
Fixes: #455