Skip to content

Use rlang::arg_match() instead of match.arg() - issue: #672 #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 2, 2022
Merged

Use rlang::arg_match() instead of match.arg() - issue: #672 #1099

merged 5 commits into from
Nov 2, 2022

Conversation

mojister
Copy link
Contributor

Summary

Use rlang::arg_match() instead of match.arg()

Related GitHub Issues and PRs

Checklist

Remarks

  • There is an error as I check the package (even before undertaking any changes) on my system. It complains about a failure in helper-render_formats.R file.

rich-iannone
rich-iannone approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit 67cf0b9 into rstudio:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use rlang::arg_match() instead of match.arg()
2 participants
@mojister @rich-iannone