Alter paren padding for no-decimal cols #1092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds some flow control to
cols_align_decimal()
for cases where the affected column is devoid of decimal marks. In those situations, the decimal mark imputed in the function should be replaced by an empty string rather than a space, and the non-breaking space should pad the numbers without parens instead of the numbers with parens.Related GitHub Issues and PRs
cols_align_decimal()
#1058Checklist
testthat
unit tests totests/testthat
for any new functionality.