Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter paren padding for no-decimal cols #1092

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

steveputman
Copy link
Contributor

Summary

This PR adds some flow control to cols_align_decimal() for cases where the affected column is devoid of decimal marks. In those situations, the decimal mark imputed in the function should be replaced by an empty string rather than a space, and the non-breaking space should pad the numbers without parens instead of the numbers with parens.

Related GitHub Issues and PRs

Checklist

@rich-iannone rich-iannone self-requested a review November 1, 2022 18:12
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and lgtm!

@rich-iannone rich-iannone merged commit 57ec24b into rstudio:master Nov 1, 2022
@steveputman steveputman deleted the nodecacctgalign branch November 1, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants