Use the APCA contrast algorithm to better select light or dark text in ideal_fgnd_color()
#1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
ideal_fgnd_color()util function add the APCA contrast also. This determines Lc contrast between overlaid text on a background color. The background is fixed and the text color is swapped to the alternative (lightordark) that maximizes contrast. The code here is adapted from the SAPC APCA (Accessible Perceptual Contrast Algorithm). The WCAG algo has been added here as a (non-default) alternative indata_color(). Here is a comparison table demonstrating the differences between the WCAG and APCA contrast schemes.