-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace stringr functions with base R equivalents #1043
Conversation
@rich-iannone Interested by this work for knitr too: yihui/knitr#1549 I don't know if all the functions are covered by your switch here or not, but definitely some overlap. Only constraint for knitr - performance. We need to be sure that we don't loose performance in the rendering process. Maybe also an issue with gt |
@cderv Many of the stringr functions are covered here by the replacements. I could definitely do the same for knitr, not a problem. A lot of the replacements in this PR are concentrated in one part of the code path (inlining styles in HTML tags). It's not any slower and that whole section will be replaced soon anyway with a fast JS-mediated function. |
Awesome ! |
This PR removes the few stringr functions that remained in the package. A handful of simple replacement functions are used instead.