Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the fmt_roman() function #1035

Merged
merged 16 commits into from
Sep 2, 2022
Merged

Add the fmt_roman() function #1035

merged 16 commits into from
Sep 2, 2022

Conversation

rich-iannone
Copy link
Member

This adds the fmt_roman() function and the corresponding vec_fmt_roman() function. This formatter takes numeric and integer values as inputs and outputs the corresponding Roman numerals.

@rich-iannone rich-iannone marked this pull request as ready for review September 2, 2022 16:39
@rich-iannone rich-iannone requested a review from cscheid September 2, 2022 16:40
Copy link
Member

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cscheid cscheid merged commit 175fa19 into master Sep 2, 2022
@rich-iannone rich-iannone deleted the fmt-roman branch September 2, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants