Skip to content

Better integrate footnote marks with table cell text rendered with fmt_markdown() #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

rich-iannone
Copy link
Member

This PR ensures that table body cell text generated from fmt_markdown() can have footnote marks inline with the produced text. This fix works both for right and left placement of the footnote marks. New testthat tests were added to address these changes.

Fixes: #993
Fixes: #893

@rich-iannone rich-iannone changed the title Better format footnote marks with table cell text rendered with fmt_markdown() Better integrate footnote marks with table cell text rendered with fmt_markdown() Aug 17, 2022
@rich-iannone rich-iannone marked this pull request as ready for review August 17, 2022 21:33
@rich-iannone rich-iannone requested a review from cscheid August 17, 2022 21:34
Copy link
Member

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context to give a fuller review here. If it fixes the immediate bug then that's good (hence I'm approving)

I'm just generally confused about fmt_markdown()? Is GT processing markdown on its own?

@rich-iannone
Copy link
Member Author

It is processing markdown on its own with the commonmark package. This has both its advantages and disadvantages (user surprise that some things don’t render the same as in R Markdown). This is a bigger issue that we can talk about somewhere down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants