Skip to content

Add return value for gtsave() #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Add return value for gtsave() #1011

merged 3 commits into from
Aug 17, 2022

Conversation

rich-iannone
Copy link
Member

This adds a return value (invisible(TRUE)) to the bottom of the gtsave() function body. This clears up the issue of unwanted printing in R Markdown / Quarto documents and usefully returns TRUE in case the user needs to log the outcome of a gtsave() call. This also adds to and cleans up documentation in gtsave().

Fixes #974

@rich-iannone rich-iannone marked this pull request as ready for review August 17, 2022 18:34
@rich-iannone rich-iannone requested a review from cscheid August 17, 2022 18:51
Copy link
Member

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rich-iannone rich-iannone merged commit e875711 into master Aug 17, 2022
@rich-iannone rich-iannone deleted the gtsave-return branch August 17, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gtsave() outputs image, ignores hide figure chunk options, ignores formatting
2 participants