Add praise and encourage arguments to graded() helpers #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
praise
andencourage
arguments that follow the same pattern ashint
.I also added
give_praise()
andgive_encouragement()
which are small wrappers around an internal S3 genericgive_random_phrase()
. This follows the same pattern asgive_code_feedback()
and if we do this again we might want to think about one more layer of abstraction (but I'm hoping that we don't need to do this again for a while).Similarly,
give_praise()
andgive_encouragement()
can be used explicitly, although the global option is likely to be the most common usage pattern.