Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update renv environment and infra #285

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

toph-allen
Copy link
Collaborator

@toph-allen toph-allen commented Jul 30, 2024

No major changes; just a single commit cherry-picked from #283.

@toph-allen toph-allen requested a review from jonkeane July 30, 2024 15:33
@toph-allen toph-allen marked this pull request as ready for review July 30, 2024 15:33
@toph-allen toph-allen requested a review from tdstein July 30, 2024 16:12
@tdstein
Copy link

tdstein commented Jul 30, 2024

Are we confident automated testing will catch any potential issues when upgrading dependencies?

@nealrichardson
Copy link
Collaborator

https://github.com/r-lib/actions/tree/v2-branch/setup-r-dependencies installs dependencies based on the package DESCRIPTION file, so this isn't relevant for CI.

@toph-allen toph-allen merged commit 06b2a55 into main Jul 30, 2024
19 checks passed
@toph-allen toph-allen deleted the toph/bump-renv-versions branch July 30, 2024 16:56
@jonkeane
Copy link
Contributor

I'm fine with keeping renv around like this, but it feels like a lot of churn + constraint on developers (they must have precisely the same versions of everything) than is helpful. Is it worth writing up an issue for discussion of if that is something we want to maintain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants