-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite rstartup to mermaid #84
Conversation
It's not currently possible to have a mermaid subgraph that proceeds in a different direction from the flowchart if there are lines between subgraphs so something a little different will have to happen with the different phases of the startup process. |
subgraph start | ||
end | ||
|
||
subgraph env[Setting Environment Variables] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks awesome! and i'm pleasantly surprised that i got the book to render with no futzing 🙌
is this figure a direct translation from the original? would you like a review to make sure nothing was missed? or do we need another kind of technical review to make sure this information is still current/accurate (in which case, we should identify an outside reviewer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version in the first commit was an exact reproduction of the flow of the previous one. I made some small changes to accommodate a limitation of mermaid but otherwise the content is identical and I don't believe the details of r startup have changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use the lightbox extension but that doesn't quite work; let me revisit that to see if there's a better way.
Co-authored-by: Shannon Pileggi <skmcclintock@gmail.com>
No description provided.