Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite rstartup to mermaid #84

Merged
merged 8 commits into from
Jun 11, 2023
Merged

rewrite rstartup to mermaid #84

merged 8 commits into from
Jun 11, 2023

Conversation

edavidaja
Copy link
Member

No description provided.

@github-actions github-actions bot temporarily deployed to pull request May 18, 2023 17:05 Inactive
@edavidaja
Copy link
Member Author

It's not currently possible to have a mermaid subgraph that proceeds in a different direction from the flowchart if there are lines between subgraphs so something a little different will have to happen with the different phases of the startup process.

@github-actions github-actions bot temporarily deployed to pull request May 18, 2023 21:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 22, 2023 16:06 Inactive
@edavidaja edavidaja requested a review from shannonpileggi May 31, 2023 17:18
@github-actions github-actions bot temporarily deployed to pull request May 31, 2023 17:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 31, 2023 17:58 Inactive
r-startup.qmd Show resolved Hide resolved
subgraph start
end

subgraph env[Setting Environment Variables]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks awesome! and i'm pleasantly surprised that i got the book to render with no futzing 🙌

is this figure a direct translation from the original? would you like a review to make sure nothing was missed? or do we need another kind of technical review to make sure this information is still current/accurate (in which case, we should identify an outside reviewer)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in the first commit was an exact reproduction of the flow of the previous one. I made some small changes to accommodate a limitation of mermaid but otherwise the content is identical and I don't believe the details of r startup have changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't tell if we are missing one DNE or if it doesn't belong b/c that line goes no where
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running is not visible in the rendered html unless you use the bottom scrollbar, but i suspect there isn't much we can do about that.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anyway to improve visibility of this text?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use the lightbox extension but that doesn't quite work; let me revisit that to see if there's a better way.

r-startup.qmd Show resolved Hide resolved
r-startup.qmd Outdated Show resolved Hide resolved
Co-authored-by: Shannon Pileggi <skmcclintock@gmail.com>
@github-actions github-actions bot temporarily deployed to pull request June 2, 2023 17:43 Inactive
@edavidaja edavidaja merged commit 47edbf9 into main Jun 11, 2023
@edavidaja edavidaja deleted the rstartup-mermaid branch June 11, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants