rails_helper template: Restore old order of support files #2785
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before rspec#2678, the suggested code snippet for loading support files loaded files in directories (e.g. `spec/support/a/b.rb`) *after* files with the same basename as those directories (e.g. `spec/support/a.rb`). This tends to be the preferrable load order, given how Ruby modules and classes are usually structured. The root cause is a difference between the alphabetic ordering of string sorting compared to `Pathname#<=>`.
|
@JonRowe suggested this approach in #2678 (comment). |
|
Side note: Is there a template for a default |
|
|
Thank you, sir. No equivalent code there, so we're good. |
|
Thank you! |
pirj
added a commit
that referenced
this pull request
Aug 27, 2024
JonRowe
pushed a commit
that referenced
this pull request
Sep 2, 2024
rails_helper template: Restore old order of support files
JonRowe
pushed a commit
that referenced
this pull request
Sep 2, 2024
|
Released in 6.1.5 (and later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #2678, the suggested code snippet for loading support files loaded files in directories (e.g.
spec/support/a/b.rb) after files with the same basename as those directories (e.g.spec/support/a.rb).This tends to be the preferrable load order, given how Ruby modules and classes are usually structured.
The root cause is a difference between the alphabetic ordering of string sorting compared to
Pathname#<=>.