Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support show type check errors in rsbuild error overlay #15

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

9aoy
Copy link
Collaborator

@9aoy 9aoy commented Dec 24, 2024

Support intercepting the rsbuild devServer done hook to display type checking errors in the rsbuild-dev-server overlay without specifying the async: false option.

inspired by https://github.com/ypresto/fork-ts-checker-async-overlay-webpack-plugin.

Related issue: web-infra-dev/rsbuild#4232

@9aoy 9aoy merged commit 7da0710 into main Dec 24, 2024
3 checks passed
@9aoy 9aoy deleted the error-overlay branch December 24, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants