Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure transport modules #253

Merged
merged 1 commit into from
May 13, 2024
Merged

restructure transport modules #253

merged 1 commit into from
May 13, 2024

Conversation

whyoleg
Copy link
Member

@whyoleg whyoleg commented Mar 2, 2024

settings.gradle.kts contains new projects/folders structure

  • rename ktor-websocket to ktor-websocket-internal and make it an implementation dependency (not exposed)
  • move all transports under rsocket-transports folder
  • drop empty modules (with just dummy files)
  • implement small DSL for including projects

@whyoleg whyoleg requested a review from OlegDokuka March 2, 2024 08:40
@whyoleg whyoleg self-assigned this Mar 2, 2024
Copy link

github-actions bot commented Mar 2, 2024

Test Results

  699 files  ±0    699 suites  ±0   30m 42s ⏱️ - 6m 30s
2 179 tests ±0  1 950 ✅ ±0  229 💤 ±0  0 ❌ ±0 
4 562 runs  ±0  4 032 ✅ ±0  530 💤 ±0  0 ❌ ±0 

Results for commit 5f29d02. ± Comparison against base commit d5c1b35.

♻️ This comment has been updated with latest results.

@whyoleg whyoleg force-pushed the build-logic branch 2 times, most recently from adb59a1 to ec8442c Compare April 15, 2024 19:45
@whyoleg whyoleg force-pushed the restructure-projects branch from ee5446e to 85e6fa9 Compare April 15, 2024 19:50
@whyoleg whyoleg force-pushed the restructure-projects branch from 85e6fa9 to 5f29d02 Compare April 15, 2024 20:01
Base automatically changed from build-logic to master May 13, 2024 20:01
…rsocket-transports `

* additionally make rsocket-transport-ktor-websocket internal module
@whyoleg whyoleg force-pushed the restructure-projects branch from 5f29d02 to c137b10 Compare May 13, 2024 20:03
@whyoleg whyoleg merged commit 4739eac into master May 13, 2024
0 of 22 checks passed
@whyoleg whyoleg deleted the restructure-projects branch May 13, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants