-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usWeightClass in statics and variable - Beta 4 #583
Comments
After 2c652cf:
(From |
Did this not make it into the last beta? Will check the next full beta. |
Seems correct on my end. Where and how do you see these values? This is what I see (and how I see it): (v4.0-beta9g) $ for f in Inter-{SemiBold,Bold,ExtraBold}.ttf; do \
ttx -i -f -s -t OS/2 $f &&
grep usWeightClass $(basename $f .ttf).O_S_2f_2.ttx; done
Dumping "Inter-SemiBold.ttf" to "Inter-SemiBold.ttx"...
Dumping 'OS/2' table...
<usWeightClass value="600"/>
Dumping "Inter-Bold.ttf" to "Inter-Bold.ttx"...
Dumping 'OS/2' table...
<usWeightClass value="700"/>
Dumping "Inter-ExtraBold.ttf" to "Inter-ExtraBold.ttx"...
Dumping 'OS/2' table...
<usWeightClass value="800"/> |
@rsms Not sure if it's related to this, but I can still see these values in the inter.css file. https://github.com/rsms/inter/blob/master/misc/dist/inter.css#L35-L40 |
I guess was looking at one of the ZIPs from the same day (with the fixed names). So closing this. |
Unrelated, but I should fix that! Thanks @stpnkcrk |
@rsms I know it's a minor thing, but is there any chance of you releasing another beta with this fix, please? |
While checking the beta static fonts you posted yesterday
Inter-4.0-d88ab4204a.zip (2023-06-08)
I noticed the
usWeightClass
on some of the fonts looks like the designspace location/coordinates rather than the weight class values.So I also checked the variable and it appears to be the same.
My understanding is that these are important especially for the variable web fonts which are setting these values in CSS.
Think there is even a FontBakery test for this.
SemiBold = 580 - should be 600
Bold = 660 - should be 700
ExtraBold = 780 - should be 800
GF discusses mapping these here:
https://googlefonts.github.io/gf-guide/variable.html#the-axis-mapping
Apparently it can be done in Glyphs or the
.designspace
file.I think this is an issue which must be addressed for GF inclusion.
But not 100% sure.
Just so you are aware this may need addressing before final.
Sorry I cannot be much help on fixing this.
Would take me about five minutes in FontLab.
But have no idea in Glyphs or this build format.
The text was updated successfully, but these errors were encountered: