This repository has been archived by the owner on May 19, 2023. It is now read-only.
fix: makes domain name sha3 to hex w/o lead 0s #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajpiar
force-pushed
the
hotfix/tokenIdWLeading0s
branch
from
d679e03 to
94538c8
Compare
jurajpiar
force-pushed
the
hotfix/tokenIdWLeading0s
branch
from
7409892 to
b3387a5
Compare
julianmrodri
approved these changes
May 14, 2020
vojtechsimetka
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rns event processor stores token ids without leading zeroes, using utility numberToHex.
This causes an issue when wanting to compare the sha3 of a search term (for searching domain by name) with the stored tokenIds.
For quick resolution I use the numberToHex function to create the same hex string format for the queries. This seems to be an unnecessary computation but we can fix that in the refactor.