Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

chore: update docker entrypoint for migrations #387

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Nov 13, 2020

No description provided.

@AuHau AuHau requested a review from nduchak November 13, 2020 07:47
@@ -1,5 +1,4 @@
#!/bin/sh

./bin/run db-sync "$@"
./bin/run precache "$@" $RIFM_PRECACHE_TARGETS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about precache, when it will be running then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need. start will continue where it ended. I assume that the updates are fairly quick so it will be only few blocks behind.

It was a design decision to require run precache in order to split the long running fetching of data from the start of blockchain from actually being ready to serve data to user... Technically the precache did not have to be there as start would just start fetching data from "latest block" (which would be the genesis block in that case)...

Copy link
Contributor Author

@AuHau AuHau Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will require to run precache on the first deployment with the migrations though... Devops will have to do that manually, but after that anymore...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear

Copy link
Contributor

@nduchak nduchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AuHau AuHau merged commit 1e0a42a into master Nov 13, 2020
@AuHau AuHau deleted the chore/update-docker-for-migrations branch November 13, 2020 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants