Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

fix: make total-capacity(offer) and size(agreement) number type #367

Merged
merged 11 commits into from
Nov 9, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Nov 5, 2020

No description provided.

@nduchak nduchak requested a review from julianmrodri November 5, 2020 17:49
@nduchak nduchak requested a review from AuHau as a code owner November 5, 2020 17:49
@nduchak nduchak self-assigned this Nov 5, 2020
Copy link
Contributor

@julianmrodri julianmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made two small comments which we might want to address.

src/services/storage/models/offer.model.ts Outdated Show resolved Hide resolved
src/services/storage/handlers/offer.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2020

This pull request introduces 1 alert when merging 017a6cf into d50a74c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@julianmrodri julianmrodri linked an issue Nov 5, 2020 that may be closed by this pull request
src/services/storage/handlers/offer.ts Outdated Show resolved Hide resolved
src/services/storage/models/offer.model.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2020

This pull request introduces 1 alert when merging 9aea1e8 into d50a74c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2020

This pull request introduces 1 alert when merging c2cf678 into d50a74c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@nduchak nduchak requested review from AuHau and julianmrodri November 6, 2020 15:32
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few docs tweaks but otherwise LGTM!

src/sequelize.ts Outdated Show resolved Hide resolved
src/sequelize.ts Outdated Show resolved Hide resolved
Co-authored-by: Adam Uhlíř <adam@uhlir.dev>
@nduchak nduchak force-pushed the feat/make-total-capacity-number-type branch from e3bf6ce to 4a40083 Compare November 9, 2020 09:51
@nduchak nduchak force-pushed the feat/make-total-capacity-number-type branch from 4a40083 to b34d96f Compare November 9, 2020 09:55
@nduchak nduchak merged commit 8b8d0dc into master Nov 9, 2020
@nduchak nduchak deleted the feat/make-total-capacity-number-type branch November 9, 2020 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when sorting Offers by Capacity - Storage
3 participants