Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Issue when sorting Offers by Capacity - Storage #368

Closed
julianmrodri opened this issue Nov 5, 2020 · 0 comments · Fixed by #367
Closed

Issue when sorting Offers by Capacity - Storage #368

julianmrodri opened this issue Nov 5, 2020 · 0 comments · Fixed by #367
Assignees
@nduchak
Labels
bug Something isn't working P1 - High service: Storage

Comments

@julianmrodri
Copy link
Contributor

julianmrodri commented Nov 5, 2020 •
edited
Loading

  • We have an issue with My offers. . If I create an offer for 1 GB, then an offer for 10 GB and then an offer for 1.5 GB. The sorting puts 1.5 GB as the maximum, and ignores the 10 GB. This is because it is comparing as strings. We should do the totalCapacity as number as this is not an amount that will be expressed in gwei, the number column is more than enough.

The values in the DB are:

image

image
@julianmrodri julianmrodri changed the title Issue with Size Filter - Storage Issue when processing Offers with Decimals in capacity- Storage Nov 5, 2020
@julianmrodri julianmrodri transferred this issue from rsksmart/rif-marketplace-ui Nov 5, 2020
@julianmrodri julianmrodri changed the title Issue when processing Offers with Decimals in capacity- Storage Issue when sorting Offers by Capacity - Storage Nov 5, 2020
@julianmrodri julianmrodri linked a pull request Nov 5, 2020 that will close this issue
fix: make total-capacity(offer) and size(agreement) number type #367
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nduchak nduchak

Labels
bug Something isn't working P1 - High service: Storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make total-capacity(offer) and size(agreement) number type rsksmart/rif-marketplace-cache
2 participants
@nduchak @julianmrodri