feat(core/storage): improved error handling, logging

src/blockchain/utils.ts

@@ -3,12 +3,16 @@ import Eth from 'web3-eth'
 import { EventEmitter } from 'events'
 import config from 'config'
 
+import { loggingFactory } from '../logger'
 import eventsEmitterFactory, { EventsEmitterOptions, PollingOptions } from './events'
 
 export function getEventsEmitterForService (serviceName: string, eth: Eth, contractAbi: AbiItem[]): EventEmitter {
   const contractAddresses = config.get<string>(`${serviceName}.contractAddress`)
   const contract = new eth.Contract(contractAbi, contractAddresses)
 
+  const logger = loggingFactory(`${serviceName}:blockchain`)
+  logger.info(`For listening on service '${serviceName}' using contract on address: ${contractAddresses}`)
+
   const eventsToListen = config.get<string[]>(`${serviceName}.events`)
   const eventsEmitterOptions = config.get<EventsEmitterOptions>(`${serviceName}.eventsEmitter`)
   const newBlockEmitterOptions = config.get<PollingOptions>(`${serviceName}.newBlockEmitter`)

src/storage/index.ts

@@ -13,6 +13,7 @@ import eventProcessor from './storage.blockchain'
 import Price from './models/price.model'
 import confFactory from '../conf'
 import { ethFactory } from '../blockchain'
+import { errorHandler } from '../utils'
 
 import pinningContractAbi from '@rsksmart/rif-marketplace-storage-pinning/build/contracts/PinningManager.json'
 
@@ -37,7 +38,7 @@ const storage: CachedService = {
     // Initialize blockchain watcher
     const eth = app.get('eth') as Eth
     const eventsEmitter = getEventsEmitterForService('storage', eth, pinningContractAbi.abi as AbiItem[])
-    eventsEmitter.on('newEvent', eventProcessor)
+    eventsEmitter.on('newEvent', errorHandler(eventProcessor, logger))
     eventsEmitter.on('error', (e: Error) => {
       logger.error(`There was unknown error in Events Emitter! ${e}`)
     })

src/utils.ts

@@ -6,6 +6,7 @@ import config from 'config'
 
 import { Config, Store, Logger } from './types'
 import { isSupportedServices, SupportedServices } from './app'
+import { EventData } from 'web3-eth-contract'
 
 const readFile = promisify(readFileCb)
 
@@ -66,6 +67,12 @@ export function validateServices (args: string[]): SupportedServices[] {
   return args as SupportedServices[]
 }
 
+export function errorHandler (fn: (event: EventData) => Promise<void>, logger: Logger): (event: EventData) => void {
+  return (event): void => {
+    fn(event).catch(err => logger.error(err))
+  }
+}
+
 export abstract class BaseCLICommand extends Command {
   static flags = {
     config: flags.string({