Skip to content

Commit

Permalink
test: Wrap proto string in std::string before comparison (envoyproxy#…
Browse files Browse the repository at this point in the history
…4238)

Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: James Synge <jamessynge@google.com>
  • Loading branch information
jamessynge authored and htuch committed Aug 27, 2018
1 parent f5e219e commit 52beb06
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/integration/hds_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,9 @@ class HdsIntegrationTest : public HttpIntegrationTest,
if (address->ip()->port() != endpoint.endpoint().address().socket_address().port_value()) {
return false;
}
// SocketAddress.address is a proto string, not std::string, so convert it before comparing.
if (address->ip()->addressAsString() !=
endpoint.endpoint().address().socket_address().address()) {
absl::string_view(endpoint.endpoint().address().socket_address().address())) {
return false;
}
return true;
Expand Down

0 comments on commit 52beb06

Please sign in to comment.