Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix https://github.com/rsetienne/DAISIE/issues/147 #148

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Fix https://github.com/rsetienne/DAISIE/issues/147 #148

merged 1 commit into from
Sep 13, 2022

Conversation

Yangshen0325
Copy link
Contributor

Fixes #147
Correctly compute number of species at present in IW simulations

@Yangshen0325
Fix rsetienne#147
19c3673 
Fixes rsetienne#147
Correctly compute number of species at present in IW simulations
@Neves-P Neves-P added the bug Something isn't working label Sep 12, 2022
@Neves-P Neves-P self-requested a review September 12, 2022 16:44
@Neves-P Neves-P self-assigned this Sep 12, 2022
@Neves-P
Copy link
Collaborator

Neves-P commented Sep 13, 2022

Hi @Yangshen0325 , thanks for the changes, well spotted error!
The build was not passing because develop was already broken, not because of any of your changes.

@Neves-P Neves-P merged commit e1c13d3 into rsetienne:develop Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neves-P Neves-P Neves-P approved these changes

Assignees

@Neves-P Neves-P

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yangshen0325 @Neves-P