Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReadExeFromReader #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ReadExeFromReader #25

wants to merge 1 commit into from

Conversation

bathina2
Copy link

@bathina2 bathina2 commented Aug 8, 2023

My team would like to integrate goversion into syft. However, syft provides a reader.
This PR creates a new method ReadExeFromReader. It expects the caller to handle the open and close of the reader.

The original ReadExe will now handle the open and close of the file and invoke this new method.

@kzantow kzantow mentioned this pull request Aug 14, 2023
Merged
@bathina2
Copy link
Author

@rsc We think goversion adds good value to image scanners that generate SBOMs. Do you think these changes are reasonable? Thanks for your time

@wagoodman wagoodman mentioned this pull request Aug 24, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bathina2 @miquella