zerolog.Logger methods should be on *Logger, not value type

[davecheney]

No description provided.

[rs]

Sorry I did not see this comment earlier. The Logger type is read-only on purpose. Do you see good reason to have those methods to be on ponters? It would imply that New return a ponter too and would force an allocation, even for temporarty (i.e. per request) sub-loggers you want to pass on the stack.

[nicbaz]

@davecheney could you please elaborate ? Is this for consistency reasons ? Efficiency ?

[davecheney]

Calling a method on a value type makes a copy of the reciever. This copying has a performance overhead, but it also can break counters and lock invariants, and can become a data race.

…

On Sat, Jun 17, 2017 at 9:32 PM, Nicolas Bazire ***@***.***> wrote: @davecheney <https://github.com/davecheney> could you please elaborate ? Is this for consistency reasons ? Efficiency ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAcA28V26n2E9hzAPlBvAVyFax70jY2ks5sE7lJgaJpZM4Nb-2x> .

[rs]

Here there is no lock and most of the data in the struct are pointers. A logger is read-only and sub loggers are copies. Why would you make it a pointer? I see no good reason for it.

[dcheney-atlassian]

ok, my mistake, please close this issue.