Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Go 1.23.0 or above (fixes #187) #188

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Require Go 1.23.0 or above (fixes #187) #188

merged 1 commit into from
Aug 30, 2024

Conversation

jub0bs
Copy link
Contributor

@jub0bs jub0bs commented Aug 30, 2024

No description provided.

@rs rs merged commit 8e9db19 into rs:master Aug 30, 2024
@rs
Copy link
Owner

rs commented Aug 30, 2024

I merged too fast. It seems like a mod file doesn't have the right format, can you please check?

@jub0bs
Copy link
Contributor Author

jub0bs commented Aug 30, 2024

@rs Are you referring to the root go.mod? What problem are you observing? Everything seems fine.

@rs
Copy link
Owner

rs commented Aug 30, 2024

Please check the CI result on main.

@rs
Copy link
Owner

rs commented Aug 30, 2024

Actually the issue is the test with go 1.17. We need to remove it.

@jub0bs
Copy link
Contributor Author

jub0bs commented Aug 30, 2024

I remember running into that issue myself. A patch version in the go directive is allowed by the modules system but, for some reason, GitHub Actions seems to choke on it. I'll open another PR to rectify this.

@rs
Copy link
Owner

rs commented Aug 30, 2024

I think it just a an action configured specifically with this go version to ensure the code was backward compatible.

@jub0bs
Copy link
Contributor Author

jub0bs commented Aug 30, 2024

Yes, I think you're right. Using only 1.23 in the version matrix in .github/workflows/go.yml fixed it: https://github.com/jub0bs/rs-cors/actions/runs/10631861024.

Apologies; failing to update the GitHub Action was an oversight on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants