-
Notifications
You must be signed in to change notification settings - Fork 163
Conversation
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
@@ -24,14 +23,15 @@ domain = { default-features = false, version = "0.5" } | |||
domain-resolv = { default-features = false, version = "0.5" } | |||
futures = { default-features = false, features = ["compat", "io-compat"], version = "0.3.5" } | |||
ipfs-unixfs = { path = "unixfs" } | |||
libp2p = { default-features = false, features = ["floodsub", "identify", "kad", "tcp-async-std", "mdns", "mplex", "noise", "ping", "yamux"], version = "0.23" } | |||
libp2p = { default-features = false, features = ["floodsub", "identify", "kad", "tcp-tokio", "mdns", "mplex", "noise", "ping", "yamux"], version = "0.23" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: soon tokio-mdns as well, mdns might still use async-std by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I was looking at the main features in search for other tokio
ones and found none - mdns
does use async-std
right now; probably gonna change soon, like you're saying.
it seems that the |
Signed-off-by: ljedrz <ljedrz@gmail.com>
The failure for future reference: https://github.com/rs-ipfs/rust-ipfs/runs/980815860#step:16:64
Did you understand from somewhere else that this could be wider issue? Could be that windows is behind a restricted dns for example or just this particular runner was without global dns.
From probably the first bad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to have even smaller Cargo.lock
I think windows is about to hang again. bors r+ |
Build succeeded: |
We already use it in
ipfs-http
, our dependencies either already use it or are compatible with it and it has some nice features that we'd like to use.Note: the
async
tests now specifymax_threads = 1
in order to make sure the multi-threaded executor is not being lenient about any hidden bugs.fixes #275