This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Remove the rocksdb feature #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <ljedrz@gmail.com>
koivunej
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
I think this is good, testing it has been quite a chore and it takes a long time to compile... Now I also realize that we haven't been testing it on CI either.
If we had been testing it, I'd be inclined to wait to allow anyone voice their concerns on it being removed, however as it's probably already rotten, if anyone wants to see rocksdb making a comeback it can always be restored (new PR, also setting up the testing).
bors r+
|
Build succeeded: |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer intend to pursue that feature; remove the related code.