Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: createImageBitmap throws DOMException if source is 0 #1422

Merged
merged 7 commits into from
Apr 5, 2024
Merged

fix: createImageBitmap throws DOMException if source is 0 #1422

merged 7 commits into from
Apr 5, 2024

Conversation

marandaneto
Copy link
Contributor

Tries to fix #1421

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d4bbe49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
rrweb Patch
rrweb-snapshot Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/types Patch
@rrweb/web-extension Patch
rrvideo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pauldambra
pauldambra approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me...

@pauldambra pauldambra mentioned this pull request Mar 12, 2024
Merged
@marandaneto marandaneto requested a review from p-mazhnik March 18, 2024 07:42
@marandaneto
Copy link
Contributor Author

@Juice10 can we merge this? just fixed the formatting issue, thanks for the patch though.

@Juice10
Copy link
Contributor

Juice10 commented Apr 5, 2024

@marandaneto if it passes CI (running now) I'll happily merge it

@marandaneto
Copy link
Contributor Author

@marandaneto if it passes CI (running now) I'll happily merge it

All happy and green :) thanks!

@Juice10 Juice10 merged commit 3d1877c into rrweb-io:master Apr 5, 2024
6 checks passed
@Juice10
Copy link
Contributor

Juice10 commented Apr 5, 2024

@marandaneto done!

@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Merged
@daibhin daibhin mentioned this pull request Apr 22, 2024
Merged
@marandaneto marandaneto mentioned this pull request Apr 26, 2024
Draft
jaj1014 pushed a commit to pendo-io/rrweb that referenced this pull request Apr 30, 2024
@marandaneto @Juice10 @jaj1014
fix: createImageBitmap throws DOMException if source is 0 (rrweb-io#1422
3d1e472 
)

* fix: createImageBitmap throws DOMException if source is 0

* code review

* fix

* Create breezy-cats-heal.md

* fix format

---------

Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
@daibhin daibhin mentioned this pull request May 3, 2024
Closed
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Jul 31, 2024
@marandaneto @Juice10 @jxiwang
fix: createImageBitmap throws DOMException if source is 0 (rrweb-io#1422
931a6bb 
)

* fix: createImageBitmap throws DOMException if source is 0

* code review

* fix

* Create breezy-cats-heal.md

* fix format

---------

Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juice10 Juice10 Juice10 approved these changes

@pauldambra pauldambra pauldambra approved these changes

@p-mazhnik p-mazhnik p-mazhnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Calling 'createImageBitmap' throws an exception
4 participants
@marandaneto @Juice10 @pauldambra @p-mazhnik