Hotfix v0.7.1 #40
Merged
Hotfix v0.7.1 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added build_payload_from_claims_prop_test.rs to include regression tests for issue #39, ensuring the fix for invalid JSON payloads with CustomClaims remains effective. Introduced generic_claims_wrap_value_prop_test.proptest-regressions to store seeds for failure cases generated by proptest. Created an empty generic_claims_wrap_value_prop_test.rs file for future test implementations.
…_claims Added proptest dependency to Cargo.toml for property-based testing. Created build_payload_from_claims_prop_test.proptest-regressions to store seeds for failure cases generated by proptest. Updated build_payload_from_claims_prop_test.rs to include detailed property tests for the build_payload_from_claims function. Added generic_claims_wrap_value_prop_test.proptest-regressions with additional seeds for failure cases. Implemented generic_claims_wrap_value_prop_test.rs to validate the correctness and robustness of the wrap_value function using property tests.
Updated set_claim method to ignore empty keys and handle null values correctly. Refactored build_payload_from_claims to ensure proper nesting and serialization of claims. Added wrap_claims and wrap_value helper functions to handle JSON object wrapping. Included comprehensive tests for various claim scenarios: Custom claim serialization Empty claims Null claims Nested structures Multiple claims Different data types
…o claims Refactored GenericBuilder to improve readability and maintainability. Added tests for dynamic claims and scenarios with no claims for V2, Local tokens. Ensured proper handling of various claim types and edge cases in the builder and parser.
Updated Cargo.toml to reflect the new version 0.7.1.
Updated Cargo.toml to reflect the new version 0.7.1.
These commits are intended to fix issue #39. feat(tests): add regression tests for issue #39 and proptest seeds Added build_payload_from_claims_prop_test.rs to include regression tests for issue #39, ensuring the fix for invalid JSON payloads with CustomClaims remains effective. Introduced generic_claims_wrap_value_prop_test.proptest-regressions to store seeds for failure cases generated by proptest. Created an empty generic_claims_wrap_value_prop_test.rs file for future test implementations. feat(tests): add property tests for wrap_value and build_payload_from_claims Added proptest dependency to Cargo.toml for property-based testing. Created build_payload_from_claims_prop_test.proptest-regressions to store seeds for failure cases generated by proptest. Updated build_payload_from_claims_prop_test.rs to include detailed property tests for the build_payload_from_claims function. Added generic_claims_wrap_value_prop_test.proptest-regressions with additional seeds for failure cases. Implemented generic_claims_wrap_value_prop_test.rs to validate the correctness and robustness of the wrap_value function using property tests. fix(generic_builder): handle empty keys and null values in claims Updated set_claim method to ignore empty keys and handle null values correctly. Refactored build_payload_from_claims to ensure proper nesting and serialization of claims. Added wrap_claims and wrap_value helper functions to handle JSON object wrapping. Included comprehensive tests for various claim scenarios: custom claim serialization, empty claims, null claims, nested structures, multiple claims, and different data types. fix(generic_builder): refactor and add tests for dynamic claims and no claims Refactored GenericBuilder to improve readability and maintainability. Added tests for dynamic claims and scenarios with no claims for V2, Local tokens. Ensured proper handling of various claim types and edge cases in the builder and parser. chore(release): bump version to 0.7.1 Updated Cargo.toml to reflect the new version 0.7.1. These changes aim to address and resolve the issues related to invalid JSON payloads when using CustomClaims as described in issue #39.
These commits are intended to fix issue #39. feat(tests): add regression tests for issue #39 and proptest seeds Added build_payload_from_claims_prop_test.rs to include regression tests for issue #39, ensuring the fix for invalid JSON payloads with CustomClaims remains effective. Introduced generic_claims_wrap_value_prop_test.proptest-regressions to store seeds for failure cases generated by proptest. Created an empty generic_claims_wrap_value_prop_test.rs file for future test implementations. feat(tests): add property tests for wrap_value and build_payload_from_claims Added proptest dependency to Cargo.toml for property-based testing. Created build_payload_from_claims_prop_test.proptest-regressions to store seeds for failure cases generated by proptest. Updated build_payload_from_claims_prop_test.rs to include detailed property tests for the build_payload_from_claims function. Added generic_claims_wrap_value_prop_test.proptest-regressions with additional seeds for failure cases. Implemented generic_claims_wrap_value_prop_test.rs to validate the correctness and robustness of the wrap_value function using property tests. fix(generic_builder): handle empty keys and null values in claims Updated set_claim method to ignore empty keys and handle null values correctly. Refactored build_payload_from_claims to ensure proper nesting and serialization of claims. Added wrap_claims and wrap_value helper functions to handle JSON object wrapping. Included comprehensive tests for various claim scenarios: custom claim serialization, empty claims, null claims, nested structures, multiple claims, and different data types. fix(generic_builder): refactor and add tests for dynamic claims and no claims Refactored GenericBuilder to improve readability and maintainability. Added tests for dynamic claims and scenarios with no claims for V2, Local tokens. Ensured proper handling of various claim types and edge cases in the builder and parser. chore(release): bump version to 0.7.1 Updated Cargo.toml to reflect the new version 0.7.1. These changes aim to address and resolve the issues related to invalid JSON payloads when using CustomClaims as described in issue #39.
These commits are intended to fix issue #39. feat(tests): add regression tests for issue #39 and proptest seeds Added build_payload_from_claims_prop_test.rs to include regression tests for issue #39, ensuring the fix for invalid JSON payloads with CustomClaims remains effective. Introduced generic_claims_wrap_value_prop_test.proptest-regressions to store seeds for failure cases generated by proptest. Created an empty generic_claims_wrap_value_prop_test.rs file for future test implementations. feat(tests): add property tests for wrap_value and build_payload_from_claims Added proptest dependency to Cargo.toml for property-based testing. Created build_payload_from_claims_prop_test.proptest-regressions to store seeds for failure cases generated by proptest. Updated build_payload_from_claims_prop_test.rs to include detailed property tests for the build_payload_from_claims function. Added generic_claims_wrap_value_prop_test.proptest-regressions with additional seeds for failure cases. Implemented generic_claims_wrap_value_prop_test.rs to validate the correctness and robustness of the wrap_value function using property tests. fix(generic_builder): handle empty keys and null values in claims Updated set_claim method to ignore empty keys and handle null values correctly. Refactored build_payload_from_claims to ensure proper nesting and serialization of claims. Added wrap_claims and wrap_value helper functions to handle JSON object wrapping. Included comprehensive tests for various claim scenarios: custom claim serialization, empty claims, null claims, nested structures, multiple claims, and different data types. fix(generic_builder): refactor and add tests for dynamic claims and no claims Refactored GenericBuilder to improve readability and maintainability. Added tests for dynamic claims and scenarios with no claims for V2, Local tokens. Ensured proper handling of various claim types and edge cases in the builder and parser. chore(release): bump version to 0.7.1 Updated Cargo.toml to reflect the new version 0.7.1. These changes aim to address and resolve the issues related to invalid JSON payloads when using CustomClaims as described in issue #39.
Pull Request SummaryDescriptionThis pull request closes #39 , which reported an invalid JSON payload when using Changes Made
Key Test Scenarios
ConclusionThe updates ensure that the Credit and thanks to @xbb for reporting the issue by opening issue #39 and for taking the time to offer a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Please provide enough information so that others can review your pull request:
Explain the details for making this change. What existing problem does the pull request solve?
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Code formatting
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).