-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False negative with Credo.Check.Readability.ModuleDoc in nested modules #1168
Comments
rrrene
added a commit
that referenced
this issue
Dec 13, 2024
Thx for reporting! 👍 I added a test reproducing this 👍 |
rrrene
added a commit
that referenced
this issue
Dec 15, 2024
Thanks for reporting this 😀 It is now fixed on You can try this by setting the Credo dep to {:credo, github: "rrrene/credo"} Please report back if your issue is solved! 👍 |
I can confirm it to be working. Many thanks for your time and effort. And thank you for this helpful project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
mix credo -v
): 1.7.10elixir -v
): Elixir 1.17.3 (compiled with Erlang/OTP 27)What were you trying to do?
When having nested module definitions, an inner module having
@moduledoc
will silence the credo check for the outer module.Consider the following code:
Expected outcome
Actual outcome
found no issues.
The text was updated successfully, but these errors were encountered: