Skip to content

Commit

Permalink
misc: rename Style to DocstringStyle
Browse files Browse the repository at this point in the history
  • Loading branch information
rr- committed May 26, 2021
1 parent ff9d937 commit 7a4334a
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 21 deletions.
6 changes: 4 additions & 2 deletions docstring_parser/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
DocstringParam,
DocstringRaises,
DocstringReturns,
ParseError,
Style,
)
from .common import DocstringStyle # backwards compatibility
from .common import DocstringStyle as Style
from .common import ParseError
from .parser import parse

__all__ = [
Expand All @@ -21,5 +22,6 @@
"DocstringRaises",
"DocstringReturns",
"DocstringDeprecated",
"DocstringStyle",
"Style",
]
6 changes: 3 additions & 3 deletions docstring_parser/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class ParseError(RuntimeError):
"""Base class for all parsing related errors."""


class Style(enum.Enum):
class DocstringStyle(enum.Enum):
"""Docstring style."""

rest = 1
Expand Down Expand Up @@ -123,15 +123,15 @@ class Docstring:

def __init__(
self,
style=None, # type: T.Optional[Style]
style=None, # type: T.Optional[DocstringStyle]
) -> None:
"""Initialize self."""
self.short_description = None # type: T.Optional[str]
self.long_description = None # type: T.Optional[str]
self.blank_after_short_description = False
self.blank_after_long_description = False
self.meta = [] # type: T.List[DocstringMeta]
self.style = style # type: T.Optional[Style]
self.style = style # type: T.Optional[DocstringStyle]

@property
def params(self) -> T.List[DocstringParam]:
Expand Down
4 changes: 2 additions & 2 deletions docstring_parser/google.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
DocstringParam,
DocstringRaises,
DocstringReturns,
DocstringStyle,
ParseError,
Style,
)


Expand Down Expand Up @@ -187,7 +187,7 @@ def parse(self, text: str) -> Docstring:
:returns: parsed docstring
"""
ret = Docstring(style=Style.google)
ret = Docstring(style=DocstringStyle.google)
if not text:
return ret

Expand Down
4 changes: 2 additions & 2 deletions docstring_parser/numpydoc.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
DocstringParam,
DocstringRaises,
DocstringReturns,
Style,
DocstringStyle,
)


Expand Down Expand Up @@ -284,7 +284,7 @@ def parse(self, text: str) -> Docstring:
:returns: parsed docstring
"""
ret = Docstring(style=Style.numpydoc)
ret = Docstring(style=DocstringStyle.numpydoc)
if not text:
return ret

Expand Down
12 changes: 6 additions & 6 deletions docstring_parser/parser.py
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
"""The main parsing routine."""

from docstring_parser import google, numpydoc, rest
from docstring_parser.common import Docstring, ParseError, Style
from docstring_parser.common import Docstring, DocstringStyle, ParseError

STYLES = {
Style.rest: rest.parse,
Style.google: google.parse,
Style.numpydoc: numpydoc.parse,
DocstringStyle.rest: rest.parse,
DocstringStyle.google: google.parse,
DocstringStyle.numpydoc: numpydoc.parse,
}


def parse(text: str, style: Style = Style.auto) -> Docstring:
def parse(text: str, style: DocstringStyle = DocstringStyle.auto) -> Docstring:
"""Parse the docstring into its components.
:param text: docstring text to parse
:param style: docstring style
:returns: parsed docstring representation
"""
if style != Style.auto:
if style != DocstringStyle.auto:
return STYLES[style](text)

rets = []
Expand Down
4 changes: 2 additions & 2 deletions docstring_parser/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
DocstringParam,
DocstringRaises,
DocstringReturns,
DocstringStyle,
ParseError,
Style,
)


Expand Down Expand Up @@ -89,7 +89,7 @@ def parse(text: str) -> Docstring:
:returns: parsed docstring
"""
ret = Docstring(style=Style.rest)
ret = Docstring(style=DocstringStyle.rest)
if not text:
return ret

Expand Down
8 changes: 4 additions & 4 deletions docstring_parser/tests/test_parser.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from docstring_parser.common import Style
from docstring_parser.common import DocstringStyle
from docstring_parser.parser import parse


Expand All @@ -21,7 +21,7 @@ def test_rest() -> None:
"""
)

assert docstring.style == Style.rest
assert docstring.style == DocstringStyle.rest
assert docstring.short_description == "Short description"
assert docstring.long_description == (
"Long description\n\n"
Expand Down Expand Up @@ -69,7 +69,7 @@ def test_google() -> None:
"""
)

assert docstring.style == Style.google
assert docstring.style == DocstringStyle.google
assert docstring.short_description == "Short description"
assert docstring.long_description == (
"Long description\n\n"
Expand Down Expand Up @@ -139,7 +139,7 @@ def test_numpydoc() -> None:
"""
)

assert docstring.style == Style.numpydoc
assert docstring.style == DocstringStyle.numpydoc
assert docstring.short_description == "Short description"
assert docstring.long_description == (
"Long description\n\n"
Expand Down

0 comments on commit 7a4334a

Please sign in to comment.