Unify marking of depraceted API, deprications page #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
force-pushed
the
deprecations
branch
2 times, most recently
from
408303b to
c303b8d
Compare
- depraceted API needs to be marked with `[[deprecated]]` attribute - depraceted API needs to be marked with `@deprecated` tag - simplify and unify messages for deprecated API
Otherwise the build fails because we treat all warnings as errors.
kontura
added
the
blocked
kontura
force-pushed
the
deprecations
branch
from
c303b8d to
9fea345
Compare
kontura
removed
the
blocked
jan-kolarik
reviewed
Feb 11, 2025
jan-kolarik
approved these changes
Feb 11, 2025
|
This requires: rpm-software-management/ci-dnf-stack#1629 |
kontura
force-pushed
the
deprecations
branch
from
9fea345 to
fccf226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also adds
ConfigMainto the docs (both cpp and python), mostly because it contains most of the deprecated API but it is an important class in general.Closes: #865