Disable several warnings that show up with rust 1.82.0(beta) #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most, I didn't find a good solution that would work with both rust 1.81.0 and 1.82.0. clippy::too_long_first_doc_paragraph is an exception, this could be solved by rephrasing the doc comments. However I didn't want to edit all the doc comments for the rom functions.
|
Ugh, it's a shame this was necessary. Your fix looks OK. |
thejpster
approved these changes
Sep 9, 2024
|
This may still change: rust-lang/rust#129352 (comment) |
The warning happening in beta will be rolled back (for now) according to rust-lang/rust#129352 (comment) Until this change propagates to a beta release, we can live with the warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most, I didn't find a good solution that would work with both rust 1.81.0 and 1.82.0.
clippy::too_long_first_doc_paragraph is an exception, this could be solved by rephrasing the doc comments. However I didn't want to edit all the doc comments for the rom functions.