-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADC fifo DMA #636
Merged
Merged
ADC fifo DMA #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method first enables the FIFO, sets FCS.THRESH = 1 and FCS.DREQ_EN = 1. Afterwards the given closure is called with an appropriate `dma::ReadTarget`, yielding either 8-bit or 16-bit samples (depending on `FCS.SHIFT`). The closure must start a DMA transfer and return it. Finally CS.START_MANY is set, and a `AdcFifo` together with the DMA transfer is returned.
Also adds methods to `pause` and `resume` FIFO capturing.
jannic
added
the
breaking change
This pull request contains a SemVer breaking change
label
Jul 8, 2023
jannic
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally found the time to actually try it out on hardware.
LGTM, and thanks for contributing!
Closed
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
This pull request contains a SemVer breaking change
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMA support for free-running ADC capture.
The basic API looks like this:
To enable this functionality, the following methods were added:
AdcFifoBuilder::enable_dma
: setsFCS.DREQ_EN = 1
andFCS.THRESH = 1
AdcFifoBuilder::prepare
: same asstart
, but does not setCS.START_MANY
just yetAdcFifo::resume
/AdcFifo::pause
: control if capturing is active (CS.START_MANY
) without reconfiguring the FIFO in any other wayAdcFifo::is_paused
: can be used to check the current stateAdcFifo::clear
: reads the FIFO until empty, discarding valuesAdcFifo::dma_read_target
: returns a struct that implementsdma::ReadTarget
, and can be used to construct the transfer. (Ifdma::ReadTarget
were implemented onAdcFifo
directly, it wouldn't be possible toresume()
the FIFO after starting the DMA transfer, because the transfer would take ownership of theAdcFifo
)