Byteswapping config #603
Merged
Byteswapping config #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wilfried Chauveau <wilfried.chauveau@ithinuel.me>
Co-authored-by: Wilfried Chauveau <wilfried.chauveau@ithinuel.me>
Co-authored-by: Wilfried Chauveau <wilfried.chauveau@ithinuel.me>
jannic
approved these changes
May 8, 2023
There was a problem hiding this comment.
LGTM, and I think the review comments from #590 were included.
As we did a minor release (0.8.1) a few days ago, I'd be fine to start applying breaking changes now. In case we need to do another minor release before 0.9.0, we can always do it from a separate branch.
jannic
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just rearranged my fork so I can add more features through different branches, sorry about having to re-create my PR.