Skip to content

Commit

Permalink
feat(kubernetes_platform): Update kubernetes_platform go package to i…
Browse files Browse the repository at this point in the history
…nclude ImagePullSecrets (kubeflow#10410)
  • Loading branch information
JosepSampe authored and roytman committed Feb 14, 2024
1 parent 03ed201 commit 076476a
Show file tree
Hide file tree
Showing 2 changed files with 83 additions and 21 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions kubernetes_platform/proto/kubernetes_executor_config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ message KubernetesExecutorConfig {
repeated PvcMount pvc_mount = 3;
NodeSelector node_selector = 4;
PodMetadata pod_metadata = 5;
repeated ConfigMapAsVolume cm_as_volume = 6;
repeated ConfigMapAsEnv cm_as_env = 7;
repeated ImagePullSecret image_pull_secret = 6;
repeated ConfigMapAsVolume cm_as_volume = 7;
repeated ConfigMapAsEnv cm_as_env = 8;
}

message SecretAsVolume {
Expand Down Expand Up @@ -125,6 +126,11 @@ message PodMetadata {
map<string, string> annotations = 2;
}

message ImagePullSecret {
// Name of the image pull secret.
string secret_name = 1;
}

message ConfigMapAsVolume {
// Name of the ConfigMap.
string config_map_name = 1;
Expand Down

0 comments on commit 076476a

Please sign in to comment.