This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
added nova dependency container comptibility and added text edit #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royduin
suggested changes
Jan 11, 2021
README.md
Outdated
| @@ -7,7 +7,7 @@ Field is based on [nova-belongs-to-dependency](https://github.com/manmohanjit/no | |||
| ## Installation | |||
|
|
|||
| ``` | |||
| composer require royduin/laravel-nova-field-dynamic-select | |||
| composer require kayacekovic/laravel-nova-field-dynamic-select | |||
composer.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "royduin/laravel-nova-field-dynamic-select", | |||
| "name": "kayacekovic/laravel-nova-field-dynamic-select", | |||
src/DynamicSelect.php
Outdated
| @@ -20,17 +20,33 @@ public function resolve($resource, $attribute = null) | |||
| return parent::resolve($resource, $attribute); | |||
| } | |||
|
|
|||
| public function placheholder($placeholder = 'Pick a value') | |||
There was a problem hiding this comment.
These methods are not executed by default so we don't have a fallback anymore right? This way a user is forced to always specify these. Plus; they are not translatable by default anymore which makes it a breaking change.
|
Thanks! Released 😎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.