Merge pull request #99 from lwabish/master

fix: logger content leakage
royalrick · Apr 23, 2023 · 360648d · 360648d
2 parents 592ab14 + f6e2d15
commit 360648d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/logger/logger.go b/logger/logger.go
@@ -97,6 +97,7 @@ func (l *logger) Info(ctx context.Context, msg string, data ...interface{}) {
 				}
 			}
 		}
+		l.info = l.info[:1]
 	}
 }
 
@@ -114,6 +115,7 @@ func (l *logger) Warn(ctx context.Context, msg string, data ...interface{}) {
 				}
 			}
 		}
+		l.warn = l.warn[:1]
 	}
 }
 
@@ -131,6 +133,7 @@ func (l *logger) Error(ctx context.Context, msg string, data ...interface{}) {
 				}
 			}
 		}
+		l.err = l.err[:1]
 	}
 }
 

diff --git a/logger/logger_test.go b/logger/logger_test.go
@@ -0,0 +1,15 @@
+package logger
+
+import (
+	"context"
+	"log"
+	"os"
+	"testing"
+)
+
+func TestLogger(t *testing.T) {
+	l := NewLogger(log.New(os.Stdout, "\r\n", log.LstdFlags), Info, true)
+	for i := 0; i < 4; i++ {
+		l.Info(context.Background(), "request url: %d", i)
+	}
+}
-Original file line number
+Diff line change
@@ Expand Up @@
     				}
     			}
     		}
+    		l.info = l.info[:1]
     	}
     }
@@ Expand All @@
     				}
     			}
     		}
+    		l.warn = l.warn[:1]
     	}
     }
@@ Expand All @@
     				}
     			}
     		}
+    		l.err = l.err[:1]
     	}
     }
@@ Expand Down @@