Threading fixes for minor UI glitches #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c variable isn't safe. Added a _laneIndex ivar to PBGitGrapher to prevent multiple instances of PBGitGrapher from interfering with each other.
…ly in the history view and sometimes having no commits show.
rowanj
added a commit
that referenced
this pull request
Jul 17, 2014
Threading fixes for minor UI glitches
|
Thanks! 👍 |
rowanj
added a commit
that referenced
this pull request
Jul 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of visual issues due to threading when the history list gets loaded multiple times concurrently.
PBGitGrapher wasn't thread-safe (was holding internal static state) and PBGitRevList wasn't handling thread cancellation correctly.