Crash on new repo #295
Merged
Crash on new repo #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latest upstream changes. Conflicts: Classes/git/PBGitCommit.h Classes/git/PBGitCommit.m Classes/git/PBGitHistoryGrapher.m Classes/git/PBGitRepository.m Classes/git/PBGitRevList.mm Classes/git/PBGitSHA.h Classes/git/PBGitSHA.m
|
I'm concerned by the Sparkle change; breaking the updates can effectively be the end-of-the-road for getting a fix. Is there some summary of the differences, and a need to update? |
Conflicts: Classes/Controllers/PBWebHistoryController.m Classes/git/PBGitCommit.h Classes/git/PBGitCommit.m Classes/git/PBGitGrapher.mm Classes/git/PBGitHistoryList.m Classes/git/PBGitRevList.mm Classes/git/PBGitSHA.h Classes/git/PBGitSHA.m
…ay the parent link in history.js.
|
You're right, I shouldn't mess with Sparkle ;-). Here's a rebased branch that includes @5sw changes (which are lovely IMHO, note that I merged in your last changelog fixes on top of it), a few fixes, and the fix for the crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a "User Cancelled" error so we don't crash when canceling "New".
Closes #275, #220.