-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch Labels in Outline view hard to read #315
Comments
If nothing else a pref to make the label text larger would be appreciate. |
+1 The old style was easier for me to read and felt more OSX-like imo. What was the goal of the label redesign? |
The release notes mentioned "higher contrast" but I too find the new rendering more difficult to read. |
I thought the old labels were just fine, no reason to mess with them. |
+1. These are ugly and less legible. The shadow on the labels and the commit markers is unnecessary. |
They looked a lot better to me on a Retina screen. I'll drop the shadows and try to find a compromise. |
They still look a lot better than the solid outline, especially on Retina; so I’m hoping this helps with the visual weighting of the readability problem.
n.b. I don't actually have a non-retina screen at hand currently; also in case that's been misunderstood, the label font hasn't been changed - it'd just been rounded and shadowed instead of outlined |
I just shrunk the image down to "half size" to match my non-Retina display. Other than the shrinking artifacts, it may be okay, especially if the native font rendering does a better job than shrinking the image in Chrome. I think the important thing to remember is that the text and the color are the critical bits of information, not the stuff surrounding it. Your change is definitely a step in that direction. |
Seeing them side-by-side like that; without the outline there is actually a little more room inside the ref label - I'll see if I can also tweak the font size at all... |
That looks pretty good to my eyes. |
Build 1899 is working all around much better than 1869 so far. All of the issues I've been keeping tabs on are in much better shape, if not fully resolved. (There isn't a good place for "generic" feedback.) |
If you're going to have a shadow, I'd much prefer it be a 90° shadow, which is the standard in the OS X UI. |
The shadow on the lines is there to separate them better when they overlap or are on the 'selected' item. I'm not adding visual style configurations; so the outstanding work on this would then be to pick an appropriate set of colours. |
Thanks for the updates! fwiw, I think things are looking great now. |
Thanks @jordan-brough - I think it's looking pretty good too, and for the most part I'm happy to let this sit until I've integrated some cool upcoming stuff. |
I'm a +1 on the new colour scheme, FWIW. I find it easier to use when they're more vibrant. |
Updated to 0.15.1869 dev today. Discovered the branch labelling are now much harder to read. Previously they were fine. The embossing/shadowing is unnecessary and destroys clarity.
The text was updated successfully, but these errors were encountered: