(fix) Use isEqual comparison for isNewOptionSelected in Creatable. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julesterrien
approved these changes
Jul 31, 2020
judemat
approved these changes
Jul 31, 2020
|
Keeping branch around to use like we do with our fork of Cleave.js in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diandra and I have recently been experiencing weirdness with onCreateOption in react-select. This is prop you use when you want to create a new contact from the dropdown, rather than select an existing one. See the Loom here: https://www.loom.com/share/032f5cd3b0ea421398ce6e3d4aa9781b.
This is an open bug in
react-selecton 3.1.0, the version we’re running. This pull request copies an open pull request which fixes this issue on the main project.The main project pull request has not received attention from the maintainer, so we made the decision to fork the project and fix it ourselves to unblock PCM.
Created this ticket to track follow up: https://warrenpay.atlassian.net/browse/FRON-2101.
I've set a reminder for myself to check the project every two weeks for updates.