Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Manager Integration #6

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Secret Manager Integration #6

merged 2 commits into from
Jul 15, 2021

Conversation

bbengfort
Copy link
Contributor

This is the final step for a complete implementation of the v1 Whisper
app. Whisper is now no longer stateless but saves both secret context
metadata and the secret itself in Google Secret Manager. Most of the
logic of interacting with secrets has been moved out of the API and into
the Secret Manager codebase.

This is the final step for a complete implementation of the v1 Whisper
app. Whisper is now no longer stateless but saves both secret context
metadata and the secret itself in Google Secret Manager. Most of the
logic of interacting with secrets has been moved out of the API and into
the Secret Manager codebase.
@bbengfort bbengfort requested a review from rebeccabilbro July 15, 2021 14:57
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #6 (095c708) into main (d873e55) will decrease coverage by 12.62%.
The diff coverage is 0.72%.

❗ Current head 095c708 differs from pull request most recent head 60c7fb9. Consider uploading reports for the commit 60c7fb9 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main       #6       +/-   ##
===========================================
- Coverage   32.69%   20.07%   -12.63%     
===========================================
  Files           8        8               
  Lines         364      563      +199     
===========================================
- Hits          119      113        -6     
- Misses        220      424      +204     
- Partials       25       26        +1     
Impacted Files Coverage Δ
pkg/secrets.go 12.03% <0.00%> (-3.54%) ⬇️
pkg/vault.go 0.00% <0.00%> (ø)
pkg/version.go 25.00% <ø> (-12.50%) ⬇️
pkg/whisper.go 44.21% <25.00%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d873e55...60c7fb9. Read the comment docs.

Copy link
Member

@rebeccabilbro rebeccabilbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice to see some familiar bits and pieces from knock 🚪 🙂

I like the inclusion of the metadata versioning, and I think it's really neat that we've figured out how to do this with no database, at least to start!

@bbengfort bbengfort merged commit a2e8910 into main Jul 15, 2021
@bbengfort bbengfort deleted the google-secret-manager branch July 15, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants