Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: components layout #19

Merged
merged 4 commits into from
Sep 7, 2021
Merged

refact: components layout #19

merged 4 commits into from
Sep 7, 2021

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Sep 7, 2021

I should have a common container for all components so that I can add elements globally to the container without duplicating the code

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #19 (04449e4) into main (7a62c17) will increase coverage by 0.15%.
The diff coverage is 75.00%.

❗ Current head 04449e4 differs from pull request most recent head 351bdf2. Consider uploading reports for the commit 351bdf2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   56.36%   56.51%   +0.15%     
==========================================
  Files          49       50       +1     
  Lines        1155     1159       +4     
  Branches       74       74              
==========================================
+ Hits          651      655       +4     
  Misses        427      427              
  Partials       77       77              
Impacted Files Coverage Δ
web/src/components/ShowFile.tsx 13.33% <ø> (ø)
web/src/layouts/Layout.tsx 100.00% <ø> (ø)
web/src/pages/AboutUs.tsx 50.00% <ø> (ø)
web/src/pages/CreateSecret.tsx 6.66% <ø> (ø)
web/src/pages/FetchSecret.tsx 55.26% <ø> (ø)
web/src/pages/Help.tsx 50.00% <ø> (ø)
web/src/styles/createSecretStyles.ts 100.00% <ø> (ø)
web/src/components/ShowSecret.tsx 50.00% <50.00%> (ø)
web/src/layouts/ContentLayout.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a62c17...351bdf2. Read the comment docs.

Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this makes a lot more sense. I think what I was missing was the name change of Layout to GlobalLayout in layouts.index.tsx -- I didn't see an implementation for GlobalLayout so wasn't sure what it was. This definitely cleans things up a lot, nice one!

@bbengfort bbengfort merged commit 55b4159 into main Sep 7, 2021
@bbengfort bbengfort deleted the fix/layout branch September 7, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants