Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: modify service file structure #18

Merged
merged 3 commits into from
Sep 7, 2021
Merged

refact: modify service file structure #18

merged 3 commits into from
Sep 7, 2021

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Sep 6, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #18 (2e0c9e7) into main (97dbf4c) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 2e0c9e7 differs from pull request most recent head 05fef72. Consider uploading reports for the commit 05fef72 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   56.31%   56.36%   +0.04%     
==========================================
  Files          51       49       -2     
  Lines        1156     1155       -1     
  Branches       75       74       -1     
==========================================
  Hits          651      651              
+ Misses        428      427       -1     
  Partials       77       77              
Impacted Files Coverage Δ
web/src/components/CreateSecretModal.tsx 50.00% <0.00%> (ø)
web/src/components/ShowSecret.tsx 50.00% <0.00%> (ø)
web/src/pages/CreateSecret.tsx 6.66% <0.00%> (ø)
web/src/pages/FetchSecret.tsx 55.26% <ø> (ø)
web/src/services/secret.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97dbf4c...05fef72. Read the comment docs.

Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the reorganization here - secret.ts is much more readable and importing directly from services using index.ts is excellent.

@bbengfort bbengfort merged commit 45cb926 into main Sep 7, 2021
@bbengfort bbengfort deleted the refact/services branch September 7, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants