Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on large file import #16

Merged
merged 5 commits into from
Sep 6, 2021
Merged

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Sep 6, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #16 (6ccb2c9) into main (ea7676c) will increase coverage by 0.14%.
The diff coverage is 46.42%.

❗ Current head 6ccb2c9 differs from pull request most recent head 23f879e. Consider uploading reports for the commit 23f879e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   56.15%   56.29%   +0.14%     
==========================================
  Files          50       51       +1     
  Lines        1154     1160       +6     
  Branches       72       73       +1     
==========================================
+ Hits          648      653       +5     
- Misses        429      430       +1     
  Partials       77       77              
Impacted Files Coverage Δ
web/src/App.tsx 100.00% <ø> (ø)
web/src/components/Dropzone.tsx 66.66% <0.00%> (-2.90%) ⬇️
web/src/components/Layout.tsx 100.00% <ø> (ø)
web/src/styles/modalStyles.ts 100.00% <ø> (ø)
web/src/components/CreateSecretModal.tsx 52.17% <52.17%> (ø)
web/src/components/Modal.tsx 75.00% <100.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bab410...23f879e. Read the comment docs.

Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, and nice catch!

@bbengfort bbengfort merged commit f090860 into main Sep 6, 2021
@bbengfort bbengfort deleted the fix/error-on-large-file-import branch September 6, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants