Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fetch secret) add fetching file support #13

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

elysee15
Copy link
Contributor

Capture d’écran 2021-08-25 à 17 50 31

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #13 (f324c84) into main (652cf39) will decrease coverage by 0.24%.
The diff coverage is 34.61%.

❗ Current head f324c84 differs from pull request most recent head 94a1024. Consider uploading reports for the commit 94a1024 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   56.39%   56.14%   -0.25%     
==========================================
  Files          49       49              
  Lines        1158     1163       +5     
  Branches       75       77       +2     
==========================================
  Hits          653      653              
- Misses        428      433       +5     
  Partials       77       77              
Impacted Files Coverage Δ
web/src/pages/CreateSecret.tsx 7.14% <0.00%> (ø)
web/src/routes/index.tsx 84.61% <ø> (ø)
web/src/styles/footerStyles.ts 100.00% <ø> (ø)
web/src/utils/utils.ts 4.25% <0.00%> (-0.51%) ⬇️
web/src/components/ShowFile.tsx 13.33% <13.33%> (ø)
web/src/components/CreateSecretFormTabs.tsx 22.22% <22.22%> (ø)
web/src/components/TabPanel.tsx 25.00% <25.00%> (ø)
web/src/components/ShowSecret.tsx 41.66% <55.55%> (ø)
web/src/components/Dropzone.tsx 69.56% <69.56%> (ø)
web/src/components/CreateSecretForm.tsx 78.94% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652cf39...94a1024. Read the comment docs.

@elysee15 elysee15 force-pushed the feat/add-file-fetching-support branch from f324c84 to 849a6b3 Compare August 25, 2021 17:54
@bbengfort
Copy link
Contributor

bbengfort commented Aug 25, 2021

@elysee15 I just went through all of the functionality and it looks great; I really like the download page and the metadata that's displayed there! I have two requests:

  1. Could we add the destroy button to the ShowFile component?
  2. Would you mind merging in the conflicts from main so I can review the code?

@elysee15 elysee15 force-pushed the feat/add-file-fetching-support branch from 849a6b3 to 94a1024 Compare August 26, 2021 11:03
Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The UI is really coming together and I think we're pretty close to feature complete. Very nice work!

@elysee15 elysee15 merged commit aa92286 into main Aug 26, 2021
@elysee15 elysee15 deleted the feat/add-file-fetching-support branch August 26, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants